[PATCH v2 04/25] mx23_olinuxino: pinephone: Enable LED

Peter Robinson pbrobinson at gmail.com
Mon Oct 21 20:37:19 CEST 2024


Hi Simon,

> Drop the STATUS_LED options and enable LED and LED_BOOT instead, since
> this is the new way to access the LED functionality.

Should this be two commits? The subject reads as pinephone is part of
another device.

> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2:
> - Add a patch to enable LED and LED_BOOT for these boards
>
>  configs/mx23_olinuxino_defconfig | 10 ++--------
>  configs/pinephone_defconfig      |  7 ++-----
>  2 files changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig
> index 3016f750e64..c1319077891 100644
> --- a/configs/mx23_olinuxino_defconfig
> +++ b/configs/mx23_olinuxino_defconfig
> @@ -39,14 +39,8 @@ CONFIG_USE_BOOTFILE=y
>  CONFIG_BOOTFILE="uImage"
>  CONFIG_VERSION_VARIABLE=y
>  CONFIG_MXS_GPIO=y
> -CONFIG_LED_STATUS=y
> -CONFIG_LED_STATUS_GPIO=y
> -CONFIG_LED_STATUS0=y
> -CONFIG_LED_STATUS_BIT=778
> -CONFIG_LED_STATUS_STATE=2
> -CONFIG_LED_STATUS_BOOT_ENABLE=y
> -CONFIG_LED_STATUS_BOOT=0
> -CONFIG_LED_STATUS_CMD=y
> +CONFIG_LED=y
> +CONFIG_LED_BOOT=y
>  CONFIG_MMC_MXS=y
>  CONFIG_CONS_INDEX=0
>  CONFIG_DM_SERIAL=y
> diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig
> index 9d39204a439..272fce1c1a4 100644
> --- a/configs/pinephone_defconfig
> +++ b/configs/pinephone_defconfig
> @@ -11,8 +11,5 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>  CONFIG_PINEPHONE_DT_SELECTION=y
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.2"
> -CONFIG_LED_STATUS=y
> -CONFIG_LED_STATUS_GPIO=y
> -CONFIG_LED_STATUS0=y
> -CONFIG_LED_STATUS_BIT=114
> -CONFIG_LED_STATUS_STATE=2
> +CONFIG_LED=y
> +CONFIG_LED_BOOT=y
> --
> 2.43.0
>


More information about the U-Boot mailing list