[PATCH v2 00/25] led: Remove old status-LED code

Tom Rini trini at konsulko.com
Mon Oct 21 19:26:13 CEST 2024


On Mon, Oct 21, 2024 at 01:38:08PM +0200, Simon Glass wrote:
> There has been an LED framework in U-Boot which uses driver model for
> about 9 years now. Recent work is underway to improve it and provide
> more features. It is probably a good time to drop the old code, which
> is only used by 5 boards:
> 
>    ./tools/qconfig.py -f LED_STATUS
>    5 matches
>    eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
>    socfpga_vining_fpga
> 
> This series attempts that.
> 
> Changes in v2:
> - Combine code-removal and defconfig changes
> - Add a patch to enable LED and LED_BOOT for these boards
> - Add a patch to enable LED and LED_BOOT for these boards
> - Enable LED on the 5 affected platforms
> - Reorder patches for bisectability

So I believe this means you missed the feedback of just doing the blind
migration rather than disabling the feature, like we used to often do
for cases where it's just a matter of changing CONFIG options. It
should:
- Not introduce a failure to build
- Just work on platforms with either OF_UPSTREAM or semi-recent device
  trees
- Just start working on those platforms when they do move to
  OF_UPSTREAM.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241021/9bb1cdff/attachment.sig>


More information about the U-Boot mailing list