[PATCH v1 1/1] efi_loader: Mark a function static

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Oct 22 08:02:46 CEST 2024


On 10/21/24 16:40, Ilias Apalodimas wrote:
> Thanks Andy
>
> On Mon, 21 Oct 2024 at 17:06, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
>>
>> efi_bootmgr_release_uridp_resource() is not used anywhere except
>> the same file where it is defined. Mark it static.
>> This helps avoiding the compiler warning:
>>
>>    lib/efi_loader/efi_bootmgr.c:388:14: warning: no previous prototype for ‘efi_bootmgr_release_uridp_resource’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>> ---
>>   lib/efi_loader/efi_bootmgr.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
>> index 589d3996b680..79144962cd73 100644
>> --- a/lib/efi_loader/efi_bootmgr.c
>> +++ b/lib/efi_loader/efi_bootmgr.c
>> @@ -385,7 +385,7 @@ err:
>>    * @ctx:       event context
>>    * Return:     status code
>>    */
>> -efi_status_t efi_bootmgr_release_uridp_resource(struct uridp_context *ctx)
>> +static efi_status_t efi_bootmgr_release_uridp_resource(struct uridp_context *ctx)
>>   {
>>          efi_status_t ret = EFI_SUCCESS;
>>
>> --
>> 2.43.0.rc1.1336.g36b5255a03ac
>>
>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

Hello Andy,

The function is called efi_bootmgr_release_uridp() since 292a4a4c7b77
("efi_loader: shorten efi_bootmgr_release_uridp_resource()").

Best regards

Heinrich



More information about the U-Boot mailing list