[PATCH 07/13] cyclic: make cyclic_run static

Stefan Roese sr at denx.de
Tue Oct 22 13:12:35 CEST 2024


On 10/3/24 23:27, Rasmus Villemoes wrote:
> The only caller left is schedule(); everybody outside cyclic.c now
> calls or references schedule().
> 
> Signed-off-by: Rasmus Villemoes <ravi at prevas.dk>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   common/cyclic.c  |  2 +-
>   include/cyclic.h | 12 ------------
>   2 files changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/common/cyclic.c b/common/cyclic.c
> index 38d815bec35..196797fd61e 100644
> --- a/common/cyclic.c
> +++ b/common/cyclic.c
> @@ -45,7 +45,7 @@ void cyclic_unregister(struct cyclic_info *cyclic)
>   	hlist_del(&cyclic->list);
>   }
>   
> -void cyclic_run(void)
> +static void cyclic_run(void)
>   {
>   	struct cyclic_info *cyclic;
>   	struct hlist_node *tmp;
> diff --git a/include/cyclic.h b/include/cyclic.h
> index e8de616dcd5..c6c463d68e9 100644
> --- a/include/cyclic.h
> +++ b/include/cyclic.h
> @@ -87,14 +87,6 @@ int cyclic_unregister_all(void);
>    */
>   struct hlist_head *cyclic_get_list(void);
>   
> -/**
> - * cyclic_run() - Interate over all registered cyclic functions
> - *
> - * Interate over all registered cyclic functions and if the it's function
> - * needs to be executed, then call into these registered functions.
> - */
> -void cyclic_run(void);
> -
>   #else
>   
>   static inline void cyclic_register(struct cyclic_info *cyclic, cyclic_func_t func,
> @@ -106,10 +98,6 @@ static inline void cyclic_unregister(struct cyclic_info *cyclic)
>   {
>   }
>   
> -static inline void cyclic_run(void)
> -{
> -}
> -
>   static inline int cyclic_unregister_all(void)
>   {
>   	return 0;

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list