[PATCH 08/13] watchdog.h: change include of cyclic.h to u-boot/schedule.h

Stefan Roese sr at denx.de
Tue Oct 22 13:12:49 CEST 2024


On 10/3/24 23:27, Rasmus Villemoes wrote:
> Nobody relies on getting the cyclic API declared by including the
> watchdog.h header, but for historical reasons, many TUs include
> watchdog.h to get a declaration of schedule(). Now that we have a
> dedicated header for just that, include that header instead of
> cyclic.h.
> 
> Eventually, all TUs that call schedule() should themselves include
> u-boot/schedule.h, but this is a step towards getting rid of
> unnecessary include statements in cyclic.h and global_data.h.
> 
> Signed-off-by: Rasmus Villemoes <ravi at prevas.dk>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   include/watchdog.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/watchdog.h b/include/watchdog.h
> index d1956fafca1..0149b44d077 100644
> --- a/include/watchdog.h
> +++ b/include/watchdog.h
> @@ -10,7 +10,7 @@
>   #ifndef _WATCHDOG_H_
>   #define _WATCHDOG_H_
>   
> -#include <cyclic.h>
> +#include <u-boot/schedule.h> // to be removed later
>   
>   /*
>    * Reset the watchdog timer, always returns 0

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list