[PATCH 13/13] global_data.h: remove unnecesary include of cyclic.h

Stefan Roese sr at denx.de
Tue Oct 22 13:14:13 CEST 2024


On 10/3/24 23:28, Rasmus Villemoes wrote:
> Nothing in cyclic.h is needed to define struct global_data, so do not
> include that header.
> 
> If any .c file relies on getting cyclic.h through asm/global_data.h,
> it needs to include it itself.
> 
> Signed-off-by: Rasmus Villemoes <ravi at prevas.dk>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   include/asm-generic/global_data.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
> index 27aa75e7036..1570ad8f0c0 100644
> --- a/include/asm-generic/global_data.h
> +++ b/include/asm-generic/global_data.h
> @@ -20,7 +20,6 @@
>    */
>   
>   #ifndef __ASSEMBLY__
> -#include <cyclic.h>
>   #include <event_internal.h>
>   #include <fdtdec.h>
>   #include <membuff.h>

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list