[PATCHv2 2/2] cpu_func.h: provide noncached_set_region prototype to fix build

Tom Rini trini at konsulko.com
Tue Oct 22 18:31:18 CEST 2024


From: Jonas Jelonek <jelonek.jonas at gmail.com>

Due to the removal of weak functions in 7d6cee2cd0 ("cmd: cache: Remove
weak function"), U-Boot fails to compile after updating to v2024.10 for
mediatek target in OpenWrt with GCC-14 with error:
cmd/cache.c: In function 'do_dcache':
cmd/cache.c:57:25: error: implicit declaration of function
	'noncached_set_region' [-Wimplicit-function-declaration]

Thus, provide a prototype in include/cpu_func.h to fix a build
error in cmd/cache.c, since related prototypes are also located there.

The issue occured after the update of uboot-mediatek in OpenWrt to
v2024.10, in combination with GCC-14 toolchain. It was reported and
discussed in https://github.com/openwrt/openwrt/issues/16697, and
temporarily fixed with
https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295.

Signed-off-by: Jonas Jelonek <jelonek.jonas at gmail.com>
Link: https://github.com/openwrt/openwrt/issues/16697
Link: https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295
Fixes: 7d6cee2cd0 ("cmd: cache: Remove weak function")
Signed-off-by: Tom Rini <trini at konsulko.com>
---
Changes in v2:
Move to cpu_func.h instead of <asm/system.h>. We do this because not all
architectures which compile cmd/cache.c have <asm/system.h>.
---
 include/cpu_func.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/cpu_func.h b/include/cpu_func.h
index dba7d102e897..7e81c4364a73 100644
--- a/include/cpu_func.h
+++ b/include/cpu_func.h
@@ -80,6 +80,7 @@ void invalidate_icache_all(void);
  * Return: 0 if OK
  */
 int noncached_init(void);
+void noncached_set_region(void);
 
 phys_addr_t noncached_alloc(size_t size, size_t align);
 
-- 
2.43.0



More information about the U-Boot mailing list