[PATCH v1 1/1] rpi: Only add frame buffer node if CONFIG_FDT_SIMPLEFB is set
Peter Robinson
pbrobinson at gmail.com
Thu Oct 24 13:29:53 CEST 2024
Hi Martin,
> The functions fdt_simplefb_add_node and fdt_simplefb_enable_and_mem_rsv
> are only available if CONFIG_FDT_SIMPLEFB is enabled.
Is this a follow up on the patch [1] you sent a month ago? If so it's
not really a v1, and you should add a chnagelog as to what's changed
as well as cc: the people that provided feedback.
[1] https://lists.denx.de/pipermail/u-boot/2024-September/565514.html
> Signed-off-by: Martin Stolpe <martin.stolpe at gmail.com>
> ---
>
> board/raspberrypi/rpi/rpi.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
> index ab5ea85cf9..47db441696 100644
> --- a/board/raspberrypi/rpi/rpi.c
> +++ b/board/raspberrypi/rpi/rpi.c
> @@ -569,11 +569,13 @@ int ft_board_setup(void *blob, struct bd_info *bd)
>
> update_fdt_from_fw(blob, (void *)fw_dtb_pointer);
>
> - node = fdt_node_offset_by_compatible(blob, -1, "simple-framebuffer");
> - if (node < 0)
> - fdt_simplefb_add_node(blob);
> - else
> - fdt_simplefb_enable_and_mem_rsv(blob);
> + if (CONFIG_IS_ENABLED(FDT_SIMPLEFB)) {
> + node = fdt_node_offset_by_compatible(blob, -1, "simple-framebuffer");
> + if (node < 0)
> + fdt_simplefb_add_node(blob);
> + else
> + fdt_simplefb_enable_and_mem_rsv(blob);
> + }
>
> #ifdef CONFIG_EFI_LOADER
> /* Reserve the spin table */
> --
> 2.43.0
>
More information about the U-Boot
mailing list