[PATCH] imx8m: set sane default value for SPL_LOAD_FIT_ADDRESS

Marek Vasut marex at denx.de
Thu Oct 24 13:51:16 CEST 2024


On 10/24/24 12:01 PM, Rasmus Villemoes wrote:
> I enabled IMX_HAB on an imx8mp board, but even though I knew about the
> implementation, I forgot that I had to provide a sane value for
> SPL_LOAD_FIT_ADDRESS. The help text for IMX_HAB doesn't mention this
> implicit requirement, and there's no build-time warning; the default
> 0x0 value just ends up being returned from
> board_spl_fit_buffer_addr(), obviously resulting in a non-booting
> board.
> 
> The existing imx8m* board configs that set a non-zero value currently
> all use 0x44000000. The actual value doesn't matter too much, but 0 is
> always wrong for imx8m platforms. So just use 0x44000000 as default
> for those platforms.
> 
> Signed-off-by: Rasmus Villemoes <ravi at prevas.dk>
> ---
>   boot/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 940389d4882..72d1f69afcd 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -231,6 +231,7 @@ config SPL_LOAD_FIT
>   config SPL_LOAD_FIT_ADDRESS
>   	hex "load address of fit image"
>   	depends on SPL_LOAD_FIT
> +	default 0x44000000 if ARCH_IMX8M
This only applies to HAB , for non-HAB the fitImage can be loaded at 
arbitrary location, do you need:

default 0x44000000 if ARCH_IMX8M && IMX_HAB

right ?


More information about the U-Boot mailing list