[PATCH] sunxi: power: axp809: Fix DCDC4 programming

[Chen-Yu Tsai]

On Tue, Oct 8, 2024 at 6:27 AM Andre Przywara <andre.przywara at arm.com> wrote:
>
> When trying to set the DCDC4 regulator, the code was accidentally
> setting the voltage register for DCDC5 (VCC-DRAM). The higher voltage
> doesn't harm the DRAM chips, but upsets the Linux regulator driver: when
> it tried to correct that, it tripped over a separate DT bug.
> The DCDC5 DT limits are 1.425 and 1.575V, which cannot bet set with the
> rail's resolution of 50mV. The kernel driver gave up, and made in turn
> the system hang, as the PMIC powers essential devices.
>
> Fix the copy&paste bug by using the correct PMIC voltage register.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>

Reviewed-by: Chen-Yu Tsai <wens at csie.org>

> ---
>  drivers/power/axp809.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/axp809.c b/drivers/power/axp809.c
> index 9e38e1a7450..ec3eca1ac4b 100644
> --- a/drivers/power/axp809.c
> +++ b/drivers/power/axp809.c
> @@ -93,7 +93,7 @@ int axp_set_dcdc4(unsigned int mvolt)
>                 return pmic_bus_clrbits(AXP809_OUTPUT_CTRL1,
>                                         AXP809_OUTPUT_CTRL1_DCDC4_EN);
>
> -       ret = pmic_bus_write(AXP809_DCDC5_CTRL, cfg);
> +       ret = pmic_bus_write(AXP809_DCDC4_CTRL, cfg);
>         if (ret)
>                 return ret;
>
> --
> 2.46.2
>