[PATCH 1/2] rockchip: rk356x: Implement checkboard() to print SoC variant

[Simon Glass]

Hi Jonas,

On Sun, 20 Oct 2024 at 00:24, Jonas Karlman <jonas at kwiboo.se> wrote:
>
> Hi Simon,
>
> On 2024-10-19 04:00, Simon Glass wrote:
> > Hi Jonas,
> >
> > On Fri, 18 Oct 2024 at 10:34, Jonas Karlman <jonas at kwiboo.se> wrote:
> >>
> >> Implement checkboard() to print current SoC model, e.g. one of:
> >>
> >>   SoC:   RK3566 v1
> >>   SoC:   RK3566 v2
> >>   SoC:   RK3566T v2
> >>   SoC:   RK3568 v2
> >>   SoC:   RK3568B2 v2
> >>   SoC:   RK3568J v2
> >>
> >> when U-Boot proper is started.
> >>
> >> Information about what SoC model, variant and version is read from OTP.
> >>
> >> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> >> ---
> >>  arch/arm/dts/rk356x-u-boot.dtsi        |  4 ++
> >>  arch/arm/mach-rockchip/rk3568/rk3568.c | 65 ++++++++++++++++++++++++++
> >>  configs/generic-rk3568_defconfig       |  2 +-
> >>  3 files changed, 70 insertions(+), 1 deletion(-)
> >>
> >
> > Instead of this, can you use add a CPU driver? Then it should happen
> > automatically - see print_cpuinfo().
>
> Unfortunately the CPU driver seem to be more related to the /cpus nodes,
> e.g. the arm cores included in these SoCs and not really related to the
> overall SoC used by the board.
>
> This instead depend on the DISPLAY_BOARDINFO and its checkboard() as the
> type of SoC seem more related to the board soc target.

OK.

Can we get plumb it into try_sysinfo()  somehow? Perhaps add a sysinfo
driver which returns a new SYSINFO_ID_SOC option?

I'm just trying to handle things using driver model, etc. rather than
weak functions.

>
> Regards,
> Jonas
>