[PATCH 1/9] mtd: spi-nor: Remove recently added nor->addr_width == 3 test

Tom Rini trini at konsulko.com
Thu Oct 31 17:58:34 CET 2024


On Sat, 26 Oct 2024 22:16:18 +0200, Marek Vasut wrote:

> Remove undocumented nor->addr_width == 3 test. This was added in commit
> 5d40b3d384dc ("mtd: spi-nor: Add parallel and stacked memories support")
> without any explanation in the commit message. Remove it.
> 
> This also has a bad side-effect which breaks READ operation of every SPI NOR
> which does not use addr_width == 3, e.g. s25fs512s does not work at all. This
> is because if addr_width != 3, rem_bank_len is always 0, and if rem_bank_len
> is 0, then read_len is 0 and if read_len is 0, then the spi_nor_read() returns
> -EIO.
> 
> [...]

Applied to u-boot/master, thanks!

-- 
Tom




More information about the U-Boot mailing list