[PATCH 02/17] acpi: x86: Write FADT in common code

[Patrick Rudolph]

On Mon, Jul 29, 2024 at 5:28 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Patrick,
>
> On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph
> <patrick.rudolph at 9elements.com> wrote:
> >
> > From: Maximilian Brune <maximilian.brune at 9elements.com>
> >
> > Write the FADT in common code since it's used on all architectures.
> > Let the cpu code fill out the FADT body by introducing a new weak
> > function acpi_fill_fadt().
>
> This should be done using the acpi_ops struct...i.e. add a new
> operation which fills allows a CPU driver to fill out the CPU info.
>
Which of the fields in FADT are related to the CPU driver?
Some fields like "preferred_pm_profile", "iapc_boot_arch" and "flags"
seem to be board specific.
How would the board specific code integrate into the acpi_ops?
As far as I understand there are no drivers for "mainboard class" devices.

> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
> > Cc: Simon Glass <sjg at chromium.org>
> > Cc: Bin Meng <bmeng.cn at gmail.com>
> > ---
> >  arch/x86/cpu/apollolake/acpi.c    | 20 +++------------
> >  arch/x86/cpu/baytrail/acpi.c      | 17 +------------
> >  arch/x86/cpu/quark/acpi.c         | 19 +-------------
> >  arch/x86/cpu/tangier/acpi.c       | 25 ++----------------
> >  arch/x86/include/asm/acpi_table.h | 12 ---------
> >  arch/x86/lib/acpi_table.c         | 23 -----------------
> >  include/acpi/acpi_table.h         |  9 +++++++
> >  lib/acpi/acpi_table.c             | 42 +++++++++++++++++++++++++++++++
> >  8 files changed, 59 insertions(+), 108 deletions(-)
>
> Regards,
> Simon