[PATCH v2] mmc: Hide mmc speed command under mmc command

Quentin Schulz quentin.schulz at cherry.de
Mon Sep 2 15:41:18 CEST 2024


Hi Marek,

On 9/2/24 3:37 PM, Marek Vasut wrote:
> The mmc speed command configuration option keeps showing up in
> Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
> under CMD_MMC to make it show up alongside the MMC command.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: AKASHI Takahiro <akashi.tkhro at gmail.com>
> Cc: Francis Laniel <francis.laniel at amarulasolutions.com>
> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Cc: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> Cc: Michal Simek <michal.simek at amd.com>
> Cc: Quentin Schulz <quentin.schulz at cherry.de>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: u-boot at lists.denx.de
> ---
> V2: Rework the commit message

Better, thanks :)

> ---
>   cmd/Kconfig | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 43f78a5aeb1..953e1f0ef2a 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1406,6 +1406,15 @@ config CMD_MMC_SWRITE
>   	  Enable support for the "mmc swrite" command to write Android sparse
>   	  images to eMMC.
>   
> +config MMC_SPEED_MODE_SET

I'm wondering if we should prefix this with CMD_ maybe? It's used in 
drivers/mmc/ though.

Anyway, not a blocker for this.

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

(You forgot Mattijs's Rb from v1 BTW)

Thanks!
Quentin


More information about the U-Boot mailing list