[PATCH 2/4] ram: rockchip: Kconfig: Fix dependency of RAM_ROCKCHIP_DEBUG

[Łukasz Czechowski]

Hi Quentin,

Fair point. Unfortunately the syntax "depends on <symbol> if <expr>"
seem to be not supported in Kconfig
I can do something like

depends on !TPL_SILENT_CONSOLE && TPL_RAM || !SPL_SILENT_CONSOLE && SPL_RAM

instead. What do you think?

Best regards,
Łukasz


czw., 29 sie 2024 o 12:19 Quentin Schulz <quentin.schulz at cherry.de> napisał(a):
>
> Hi Lukasz,
>
> On 8/27/24 4:20 PM, Lukasz Czechowski wrote:
> > The RAM_ROCKCHIP_DEBUG can be used only if DEBUG_UART is
> > available, otherwise it won't have any effect.
> > Add negative dependency to TPL_SILENT_CONSOLE.
> >
> > Signed-off-by: Lukasz Czechowski <lukasz.czechowski at thaumatec.com>
> > ---
> >   drivers/ram/rockchip/Kconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ram/rockchip/Kconfig b/drivers/ram/rockchip/Kconfig
> > index 67c63ecba04..4a6a6328676 100644
> > --- a/drivers/ram/rockchip/Kconfig
> > +++ b/drivers/ram/rockchip/Kconfig
> > @@ -15,6 +15,8 @@ if RAM_ROCKCHIP
> >
> >   config RAM_ROCKCHIP_DEBUG
> >       bool "Rockchip ram drivers debugging"
> > +     depends on DEBUG_UART
> > +     depends on !TPL_SILENT_CONSOLE
>
> I am wondering if we should also do this for TPL-less systems? i.e. the
> ones for which the dram is configured in SPL.
>
> Something like:
>
> depends on !SPL_SILENT_CONSOLE if SPL_RAM
> depends on !TPL_SILENT_CONSOLE if TPL_RAM
>
> maybe?
>
> Cheers,
> Quentin