[PATCH 2/7] usb: onboard-hub: Fix the return values of regulator APIs

Marek Vasut marex at denx.de
Mon Sep 2 20:45:49 CEST 2024


On 6/5/24 12:02 PM, Venkatesh Yadav Abbarapu wrote:
> Use the regulator API's only if the config DM_REGULATOR is enabled.
> Don't error out if there is no vdd regulator supply, as these are
> optional properties.
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
> ---
>   common/usb_onboard_hub.c | 22 ++++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/common/usb_onboard_hub.c b/common/usb_onboard_hub.c
> index 2f6fb71935d..0cfaa90fce3 100644
> --- a/common/usb_onboard_hub.c
> +++ b/common/usb_onboard_hub.c
> @@ -30,16 +30,22 @@ static int usb_onboard_hub_probe(struct udevice *dev)
>   	struct onboard_hub *hub = dev_get_priv(dev);
>   	int ret;
>   
> -	ret = device_get_supply_regulator(dev, "vdd-supply", &hub->vdd);
> -	if (ret) {
> -		dev_err(dev, "can't get vdd-supply: %d\n", ret);
> -		return ret;

Handle -ENOSYS (regulator support not available) return value here and 
you wouldn't need all the ifdeffery.


More information about the U-Boot mailing list