[PATCH 13/20] arm: SC598-SOM-EZKIT initial support

[Tom Rini]

On Wed, Aug 28, 2024 at 11:02:21AM +0100, Oliver Gaskell wrote:

> Adds support for Analog Devices' SC598-SOM-EZKIT board. Includes:
> - CONFIG options common to all SC5xx SoCs
> - SoC specific configs in mach-sc5xx/Kconfig
> - Memory Map for SPL
> - Necessary board-specific init functions
> - Board-specific Kconfig and environment in board/adi/
> - Memory configuration
> 
> Co-developed-by: Greg Malysa <greg.malysa at timesys.com>
> Co-developed-by: Nathan Barrett-Morrison <nathan.morrison at timesys.com>
> Co-developed-by: Trevor Woerner <twoerner at gmail.com>
> Signed-off-by: Oliver Gaskell <Oliver.Gaskell at analog.com>
[snip]
> +	#ifdef CONFIG_SC59X_64
> +	u32 *to = (void *)&__bss_start;
> +	int i, sz;
> +
> +	sz = &__bss_end - &__bss_start;
> +	for (i = 0; i < sz; i += 4)
> +		*to++ = 0;
> +	#endif

No leading spaces on '#' and use if (IS_ENABLED(CONFIG...)) {} when
possible.

> +config SPL_BSS_START_ADDR
> +	hex
> +	default 0x200B0000

You don't need "hex" here and elsewhere. For many of these, if we have a
list of defaults in the main Kconfig which has that option, please add
yours there as well. This too applies to the rest of the series, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240904/c10237bd/attachment.sig>