[PATCH v5] mmc: Poll CD in case cyclic framework is enabled

[Tom Rini]

On Sun, Jun 16, 2024 at 04:58:49PM +0200, Marek Vasut wrote:

> In case the cyclic framework is enabled, poll the card detect of already
> initialized cards and deinitialize them in case they are removed. Since
> the card initialization is a longer process and card initialization is
> done on first access to an uninitialized card anyway, avoid initializing
> newly detected uninitialized cards in the cyclic callback.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Jaehoon Chung <jh80.chung at samsung.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Simon Glass <sjg at chromium.org>
> ---
> V2: Move the cyclic registration/unregistration into mmc init/deinit
> V3: Replace if (CONFIG_IS_ENABLED(CYCLIC)...) with #if as the former
>     does not work with structure members
> V4: Stuff the code with CONFIG_IS_ENABLED() variants to avoid #ifdefs
> V5: Rebase on u-boot/next

Sorry for the delay here, this no longer builds:
   sandbox:  +   sandbox
+(sandbox) drivers/mmc/mmc.c: In function ‘mmc_init’:
+(sandbox) drivers/mmc/mmc.c:3081:56: error: passing argument 1 of ‘cyclic_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
+(sandbox)  3081 |                         (mmc->cyclic = cyclic_register(mmc_cyclic_cd_poll,
+(sandbox)       |                                                        ^~~~~~~~~~~~~~~~~~
+(sandbox)       |                                                        |
+(sandbox)       |                                                        void (*)(void *)
+(sandbox) include/linux/kconfig.h:97:23: note: in definition of macro ‘__unwrap’
+(sandbox)    97 | #define __unwrap(...) __VA_ARGS__
+(sandbox)       |                       ^~~~~~~~~~~
+(sandbox) include/linux/kconfig.h:95:26: note: in expansion of macro ‘__unwrap1’
+(sandbox)    95 | #define ___concat(a, b)  a ## b
+(sandbox)       |                          ^
+(sandbox) include/linux/kconfig.h:102:46: note: in expansion of macro ‘__CONFIG_IS_ENABLED_3’
+(sandbox)   102 | #define __CONFIG_IS_ENABLED_2(option, case1) __CONFIG_IS_ENABLED_3(option, case1, ())
+(sandbox)       |                                              ^~~~~~~~~~~~~~~~~~~~~
+(sandbox) include/linux/kconfig.h:95:26: note: in expansion of macro ‘__CONFIG_IS_ENABLED_2’
+(sandbox) drivers/mmc/mmc.c:3080:17: note: in expansion of macro ‘CONFIG_IS_ENABLED’
+(sandbox)  3080 |                 CONFIG_IS_ENABLED(CYCLIC,
+(sandbox)       |                 ^~~~~~~~~~~~~~~~~
+(sandbox) In file included from include/asm-generic/global_data.h:24,
+(sandbox)                  from arch/sandbox/include/asm/global_data.h:26,
+(sandbox)                  from include/dm/of.h:10,
+(sandbox)                  from include/dm/ofnode.h:12,
+(sandbox)                  from include/dm/device.h:13,
+(sandbox)                  from include/dm.h:13,
+(sandbox)                  from drivers/mmc/mmc.c:13:
+(sandbox) include/cyclic.h:63:42: note: expected ‘struct cyclic_info *’ but argument is of type ‘void (*)(void *)’
+(sandbox)    63 | void cyclic_register(struct cyclic_info *cyclic, cyclic_func_t func,
+(sandbox)       |                      ~~~~~~~~~~~~~~~~~~~~^~~~~~
+(sandbox) In file included from <command-line>:
+(sandbox) drivers/mmc/mmc.c:3082:56: error: passing argument 2 of ‘cyclic_register’ makes pointer from integer without a cast [-Werror=int-conversion]
+(sandbox)  3082 |                                                        100 * 1000,
+(sandbox)       |                                                        ^~~~~~~~~~
+(sandbox)       |                                                        int
+(sandbox) include/cyclic.h:63:64: note: expected ‘cyclic_func_t’ {aka ‘void (*)(struct cyclic_info *)’} but argument is of type ‘int’
+(sandbox)       |                                                  ~~~~~~~~~~~~~~^~~~
+(sandbox) drivers/mmc/mmc.c:3083:64: error: passing argument 3 of ‘cyclic_register’ makes integer from pointer without a cast [-Werror=int-conversion]
+(sandbox)  3083 |                                                        mmc->cfg->name, mmc)));
+(sandbox)       |                                                        ~~~~~~~~^~~~~~
+(sandbox)       |                                                                |
+(sandbox)       |                                                                const char *
+(sandbox) include/cyclic.h:64:31: note: expected ‘uint64_t’ {aka ‘long long unsigned int’} but argument is of type ‘const char *’
+(sandbox)    64 |                      uint64_t delay_us, const char *name);
+(sandbox)       |                      ~~~~~~~~~^~~~~~~~
+(sandbox) drivers/mmc/mmc.c:3083:72: error: passing argument 4 of ‘cyclic_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
+(sandbox)       |                                                                        ^~~
+(sandbox)       |                                                                        |
+(sandbox)       |                                                                        struct mmc *
+(sandbox) include/cyclic.h:64:53: note: expected ‘const char *’ but argument is of type ‘struct mmc *’
+(sandbox)       |                                         ~~~~~~~~~~~~^~~~
+(sandbox) drivers/mmc/mmc.c:3081:38: error: void value not ignored as it ought to be
+(sandbox)       |                                      ^
+(sandbox) cc1: all warnings being treated as errors
+(sandbox) make[3]: *** [scripts/Makefile.build:256: drivers/mmc/mmc.o] Error 1
+(sandbox) make[2]: *** [scripts/Makefile.build:397: drivers/mmc] Error 2
+(sandbox) make[1]: *** [Makefile:1897: drivers] Error 2
+(sandbox) make: *** [Makefile:177: sub-make] Error 2
 
-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240905/74c62c1c/attachment.sig>