[Binman] Question regarding SPL symbol offsets generation

[Simon Glass]

Hi Lukasz,

On Thu, 5 Sept 2024 at 07:54, Lukasz Majewski <lukma at denx.de> wrote:
>
> Hi Adam,
>
> > On Wed, Aug 28, 2024 at 3:04 AM Lukasz Majewski <lukma at denx.de> wrote:
> > >
> > > Hi Simon,
> > >
> > > > Hi,
> > > >
> > > > On Tue, 27 Aug 2024 at 12:47, Fabio Estevam <festevam at gmail.com>
> > > > wrote:
> > > > >
> > > > > Hi Lukasz,
> > > > >
> > > > > On Thu, Aug 15, 2024 at 5:14 PM Lukasz Majewski <lukma at denx.de>
> > > > > wrote:
> > > > > > Unfortunately not - this change is only for properly setting
> > > > > > start address of the u-boot.
> > > > > >
> > > > > > The _real_ problem here is the symbol placement generated by
> > > > > > binman when we try to define the image as a single one.
> > > > > >
> > > > > > Moreover, this change follows other boards with imx8mm
> > > > > > processor - ./configs/imx8mm_beacon_fspi_defconfig to be
> > > > > > specific.
> > > > > >
> > > > > > The "fix" (for which I'd been now probably opt) for this issue
> > > > > > would be to generate two images with binman - one for
> > > > > > u-boot-spl-ddr.bin and the final flash.bin with the former one
> > > > > > included (as it was before SHA1:
> > > > > > 37e50627efacd8dae18b564e9d8886a033e181bc)
> > > > >
> > > > > Is QSPI boot broken on i.MX8MM?
> > > > >
> > > > > I am adding Adam and Mamta who have tested QSPI booting on
> > > > > imx8mm_beacon and imx8mm_evk, respectively.
> > > >
> > > > Note also that I sent a series[1] which allows the symbols-base
> > > > to be adjusted, if that helps.
> > >
> > > I've seen them - but not yet tested.
> > >
> > > Thanks Simon for the patch series.
> >
> > Is it still broken with this patch series?  I have been traveling and
> > haven't had much time to test.
>
> Yes, I can confirm that it is still broken.
>
> I've applied:
> https://patchwork.ozlabs.org/project/uboot/cover/20240826191143.426387-1-sjg@chromium.org/
>
> on top of mainline:
> SHA1: 1630ff26cc960439b5949b80cfc604a2c8aa47dd
>
> Adding symbols-base = <0>; to imx8mm-u-boot.dtsi did not help.

Can you please point me to the tree? I suspect that the symbols-base
is already 0, so setting it to 0 has no effect. I'm not sure though,

Regards,
Simon