[PATCH] xilinx: versal-net: fix no previous prototype for function warning.

Michal Simek michal.simek at amd.com
Fri Sep 6 08:50:40 CEST 2024



On 9/5/24 13:57, Prasad Kummari wrote:
> Included the SPI header to resolve the no previous prototypes
> for function. Removed unused mode variable.
> sparse warnings
> warning: no previous prototype for 'spi_get_env_dev'
> [-Wmissing-prototypes]
> warning: variable 'mode' set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Prasad Kummari <prasad.kummari at amd.com>
> ---
>   board/xilinx/versal-net/board.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/board/xilinx/versal-net/board.c b/board/xilinx/versal-net/board.c
> index 1d67e3f318..4d5913cff1 100644
> --- a/board/xilinx/versal-net/board.c
> +++ b/board/xilinx/versal-net/board.c
> @@ -12,6 +12,7 @@
>   #include <env_internal.h>
>   #include <log.h>
>   #include <malloc.h>
> +#include <spi.h>
>   #include <time.h>
>   #include <asm/cache.h>
>   #include <asm/global_data.h>
> @@ -196,7 +197,6 @@ static u8 versal_net_get_bootmode(void)
>   int spi_get_env_dev(void)
>   {
>   	struct udevice *dev;
> -	const char *mode = NULL;
>   	int bootseq = -1;
>   
>   	switch (versal_net_get_bootmode()) {
> @@ -207,7 +207,6 @@ int spi_get_env_dev(void)
>   			debug("QSPI driver for QSPI device is not present\n");
>   			break;
>   		}
> -		mode = "xspi";
>   		bootseq = dev_seq(dev);
>   		break;
>   	case QSPI_MODE_32BIT:
> @@ -217,7 +216,6 @@ int spi_get_env_dev(void)
>   			debug("QSPI driver for QSPI device is not present\n");
>   			break;
>   		}
> -		mode = "xspi";
>   		bootseq = dev_seq(dev);
>   		break;
>   	case OSPI_MODE:
> @@ -227,7 +225,6 @@ int spi_get_env_dev(void)
>   			debug("OSPI driver for OSPI device is not present\n");
>   			break;
>   		}
> -		mode = "xspi";
>   		bootseq = dev_seq(dev);
>   		break;
>   	default:

Nice.

Applied.
M


More information about the U-Boot mailing list