[PATCH v4 10/15] net: fec_mxc_init(): do not ignore return status of fec_open()

Jerome Forissier jerome.forissier at linaro.org
Wed Sep 11 11:58:23 CEST 2024


The fec_mxc_init() function currently always returns 0. This does not
allow the callers to detect when for instance the PHY initialization
failed due to the port being unconnected. Fix that by returning the
status of fec_open().

Signed-off-by: Jerome Forissier <jerome.forissier at linaro.org>
Reviewed-by: Fabio Estevam <festevam at gmail.com>
Reviewed-by: Peter Robinson <pbrobinson at gmail.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
---
 drivers/net/fec_mxc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 0a0d92bc2cd..2dc1364beec 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -615,8 +615,7 @@ static int fecmxc_init(struct udevice *dev)
 	if (fec->xcv_type != SEVENWIRE)
 		miiphy_restart_aneg(dev);
 #endif
-	fec_open(dev);
-	return 0;
+	return fec_open(dev);
 }
 
 /**
-- 
2.40.1



More information about the U-Boot mailing list