[PATCH v6 07/12] test/cmd/wget: fix the test
Simon Glass
sjg at chromium.org
Thu Sep 12 02:59:53 CEST 2024
On Mon, 9 Sept 2024 at 16:27, Mikhail Kshevetskiy
<mikhail.kshevetskiy at iopsys.eu> wrote:
>
> The wget test seriously broken:
> * Uses zero values for ISS and IRS values (see RFC 9293).
> * Writes incorrect values to Sequence and Acknowledgment numbers fields
> of tcp packets. In the real life such packets will break the tcp stream.
> * The test should fail (see above), but due to buggy old tcp implementation
> it passes.
>
> This patch fix all bugs mentioned above, so the test passes with new
> and better tcp implementation.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> ---
> arch/sandbox/include/asm/eth.h | 4 +++
> test/cmd/wget.c | 45 ++++++++++++++++++++++++----------
> 2 files changed, 36 insertions(+), 13 deletions(-)
>
Reviewed-by: Simon Glass <sjg at chromium.org>
Thanks for tidying this up
More information about the U-Boot
mailing list