[PATCH v3 13/30] acpi: acpi_table: Support ACPI 2.0 platforms

Simon Glass sjg at chromium.org
Thu Sep 12 03:01:41 CEST 2024


Hi Patrick,

On Wed, 11 Sept 2024 at 03:46, Peter Robinson <pbrobinson at gmail.com> wrote:
>
> > On platforms that do not have usable DRAM below 4GiB, like QEMU sbsa,
> > the RSDT cannot be used. Allow both RSDT and XSDT to be null and only
> > fill those tables that are present in acpi_add_table().
>
> I'm not sure what ACPI 2.0 from the subject has to do with the above,
> eg ACPI only started supporting aarch64 with ACPI 5.1

Should perhaps be something like 'Support platforms without an RSDR'?

>
> > Fixes a crash on QEMU sbsa.
> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
> > Cc: Simon Glass <sjg at chromium.org>
> > Cc: Tom Rini <trini at konsulko.com>
> > ---
> >  lib/acpi/acpi_table.c | 95 ++++++++++++++++++++++++++-----------------
> >  1 file changed, 57 insertions(+), 38 deletions(-)
> >

Reviewed-by: Simon Glass <sjg at chromium.org>

I was trying to see if this patch could be split into something which
refactors the code and then another patch to fix the bug, but I can't
see it.

Regards,
Simon


More information about the U-Boot mailing list