[PATCH v9 35/37] [TESTING] Kconfig: enable NET_LWIP by default except for SANDBOX

[Simon Glass]

Hi Tom,

On Thu, 5 Sept 2024 at 00:32, Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, Sep 01, 2024 at 02:09:43PM -0600, Simon Glass wrote:
> > Hi Ilias,
> >
> > On Fri, 30 Aug 2024 at 03:27, Ilias Apalodimas
> > <ilias.apalodimas at linaro.org> wrote:
> > >
> > > Hi Simon,
> > >
> > > On Fri, 30 Aug 2024 at 03:59, Simon Glass <sjg at chromium.org> wrote:
> > > >
> > > > Hi Jerome,
> > > >
> > > > On Thu, 29 Aug 2024 at 10:21, Jerome Forissier
> > > > <jerome.forissier at linaro.org> wrote:
> > > > >
> > > > >
> > > > >
> > > > > On 8/29/24 16:05, Simon Glass wrote:
> > > > > > Hi Jerome,
> > > > > >
> > > > > > On Fri, 23 Aug 2024 at 07:50, Jerome Forissier
> > > > > > <jerome.forissier at linaro.org> wrote:
> > > > > >>
> > > > > >> Enable NET_LWIP by default for testing purposes. SANDBOX doesn't support
> > > > > >> NET_LWIP so default to NET in this case.
> > > > > >
> > > > > > Sandbox needs to support NET_LWIP.
> > > > >
> > > > > I agree in principle, but AFAICT it is not a trivial task. Does it have to
> > > > > be done in this series or can it be dealt with later?
> > > >
> > > > Does it build OK with sandbox? We use it for almost all of our feature
> > > > development and testing, so I cannot imagine bringing this in if it
> > > > doesn't work. How did you develop this feature?
> > >
> > > sandbox is deeply rooted into the old network stack. It fakes ACK
> > > responses, handles the ping request/replies with the sandbox ethernet
> > > driver etc. I was looking on adding LWIP support for it, but it's not
> > > trivial and I don't want us to add another hacky 'glue layer'. Since
> > > LWIP is a big feature on its own -- and is working on real hardware
> > > and QEMU, we discussed adding it, so people can test and contribute
> > > fixes while we fix sandbox.
> >
> > At the very least it needs to build on sandbox.
>
> It builds with sandbox, one of my tests is to switch the global default
> to lwIP and make sure nothing blows up.
>
> > I am not sure what tests LWIP has. The U-Boot networking tests are
> > very simple on sandbox. The test provides a handler to generate a
> > packet that it wants, then does a networking operation. It should not
> > be hard to plumb that through.
> >
> > I am nervous about this going in with an intention to fix it up later...
>
> We have two flavours of tests. One is the sandbox-specific state
> machines, and the other is functional testing. This series passes
> functional testing while adding another functional test (for wget). I'm
> quite fine with having sandbox figure out lwIP be a later TODO.

OK, well let's not leave it too long. It makes tests nice and simple
to write - just a function that can parse and generate any required
packets.

Also if someone can answer my first question (what tests LWIP has)
that would help.

Regards,
Simon