[PATCH 18/19] boot: Imply CRC8 with VBE

Simon Glass sjg at chromium.org
Fri Sep 20 09:25:46 CEST 2024


Hi Tom,

On Thu, 29 Aug 2024 at 19:31, Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Aug 29, 2024 at 08:58:01AM -0600, Simon Glass wrote:
> > VBE uses a crc8 checksum to verify that the nvdata is valid, so make
> > sure it is available if VBE is enabled.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  boot/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/boot/Kconfig b/boot/Kconfig
> > index afe04c7327a..49e99e5e155 100644
> > --- a/boot/Kconfig
> > +++ b/boot/Kconfig
> > @@ -716,6 +716,8 @@ config SPL_BOOTMETH_VBE_REQUEST
> >  config BOOTMETH_VBE_SIMPLE
> >       bool "Bootdev support for VBE 'simple' method"
> >       default y
> > +     imply SPL_CRC8
> > +     imply VPL_CRC8
> >       help
> >         Enables support for VBE 'simple' boot. This allows updating a single
> >         firmware image in boot media such as MMC. It does not support any sort
>
> I really worry the lack of "if SPL" / "if VPL" here leads to Kconfig
> warnings that CI doesn't pick up.

So far, BOOTMETH_VBE requires SPL and VPL, but I've added the
condition just to be safe.

Regards,
Simon


More information about the U-Boot mailing list