[PATCH v3 08/15] log: Avoid including function names by default

Simon Glass sjg at chromium.org
Fri Sep 20 18:01:13 CEST 2024


Hi Quentin,

On Mon, 12 Aug 2024 at 11:42, Quentin Schulz <quentin.schulz at cherry.de> wrote:
>
> Hi Simon,
>
> On 8/11/24 2:29 PM, Simon Glass wrote:
> > Unless function names are requested, the logging system should not
> > compile these into the code. Adjust the macros to handle this.
> >
> > This means that turning on function names at runtime won't work unless
> > CONFIG_LOGF_FUNC is enabled. We could perhaps split this into a
> > separate option if that is a problem.
> >
> > Enable CONFIG_LOGF_FUNC logging for sandbox since the tests expect the
> > function names to be included. Fix up the pinmux test which checks a
> > logging statement.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v2)
> >
>
> You did make some changes though:
> common/log_syslog.c wasn't patched in v2.
>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Ah yes, I fixed the v3 changelog in v4 [1]

Regards,
Simon

[1] https://patchwork.ozlabs.org/project/uboot/patch/20240822135503.2363706-8-sjg@chromium.org/


More information about the U-Boot mailing list