[PATCH v4 05/11] led: implement LED activity API
Christian Marangi
ansuelsmth at gmail.com
Sat Sep 21 00:49:58 CEST 2024
Implement LED activity API similar to BOOT LED API.
Usual activity might be a file transfer with TFTP, a flash write...
User of this API will call led_activity_on/off/blink() to signal these
kind of activity.
New Kconfig is implemented similar to BOOT LED, LED_ACTIVITY to
enable support for it.
It's introduced a new /options/u-boot property "activity-led" and
"activity-led-period" to define the activity LED label and the
default period when the activity LED is set to blink mode.
If "activity-led-period" is not defined, the value of 250 (ms) is
used by default.
If CONFIG_LED_BLINK or CONFIG_LED_SW_BLINK is not enabled,
led_boot_blink call will fallback to simple LED ON.
Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
---
drivers/led/Kconfig | 8 ++++
drivers/led/led-uclass.c | 94 ++++++++++++++++++++++++++++++++++++++--
include/led.h | 52 ++++++++++++++++++++++
3 files changed, 151 insertions(+), 3 deletions(-)
diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
index 6149cfa02b8..f0434f247a4 100644
--- a/drivers/led/Kconfig
+++ b/drivers/led/Kconfig
@@ -16,6 +16,14 @@ config LED_BOOT
LED boot is a specific LED assigned to signal boot operation status.
+config LED_ACTIVITY
+ bool "Enable LED activity support"
+ help
+ Enable LED activity support.
+
+ LED activity is a specific LED assigned to signal activity operation
+ like file trasnfer, flash write/erase...
+
config LED_BCM6328
bool "LED Support for BCM6328"
depends on LED && ARCH_BMIPS
diff --git a/drivers/led/led-uclass.c b/drivers/led/led-uclass.c
index c5b560982b0..c87fc7540c7 100644
--- a/drivers/led/led-uclass.c
+++ b/drivers/led/led-uclass.c
@@ -168,12 +168,86 @@ int led_boot_blink(void)
#endif
#endif
+#ifdef CONFIG_LED_ACTIVITY
+int led_activity_on(void)
+{
+ struct uclass *uc = uclass_find(UCLASS_LED);
+ struct led_uc_priv *priv;
+ struct udevice *dev;
+
+ if (!uc)
+ return -ENOENT;
+
+ priv = uclass_get_priv(uc);
+ if (!priv->activity_led_dev ||
+ uclass_get_device_tail(priv->activity_led_dev, 0, &dev)) {
+ printf("Failed to get activity LED %s\n",
+ priv->activity_led_label);
+ return -EINVAL;
+ }
+
+ return led_set_state(dev, LEDST_ON);
+}
+
+int led_activity_off(void)
+{
+ struct uclass *uc = uclass_find(UCLASS_LED);
+ struct led_uc_priv *priv;
+ struct udevice *dev;
+
+ if (!uc)
+ return -ENOENT;
+
+ priv = uclass_get_priv(uc);
+ if (!priv->activity_led_dev ||
+ uclass_get_device_tail(priv->activity_led_dev, 0, &dev)) {
+ printf("Failed to get activity LED %s\n",
+ priv->activity_led_label);
+ return -EINVAL;
+ }
+
+ return led_set_state(dev, LEDST_OFF);
+}
+
+#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK)
+int led_activity_blink(void)
+{
+ struct uclass *uc = uclass_find(UCLASS_LED);
+ struct led_uc_priv *priv;
+ struct udevice *dev;
+ int ret;
+
+ if (!uc)
+ return -ENOENT;
+
+ priv = uclass_get_priv(uc);
+ if (!priv->activity_led_dev ||
+ uclass_get_device_tail(priv->activity_led_dev, 0, &dev)) {
+ printf("Failed to get activity LED %s\n",
+ priv->activity_led_label);
+ return -EINVAL;
+ }
+
+ ret = led_set_period(dev, priv->activity_led_period);
+ if (ret) {
+ if (ret != -ENOSYS)
+ return ret;
+
+ /* fallback to ON with no set_period and no SW_BLINK */
+ return led_set_state(dev, LEDST_ON);
+ }
+
+ return led_set_state(dev, LEDST_BLINK);
+}
+#endif
+#endif
+
static int led_post_bind(struct udevice *dev)
{
struct led_uc_plat *uc_plat = dev_get_uclass_plat(dev);
const char *default_state;
-#ifdef CONFIG_LED_BOOT
+#if defined(CONFIG_LED_BOOT) || defined(CONFIG_LED_ACTIVITY)
struct led_uc_priv *priv = uclass_get_priv(dev->uclass);
#endif
@@ -189,6 +263,12 @@ static int led_post_bind(struct udevice *dev)
priv->boot_led_dev = dev;
#endif
+#ifdef CONFIG_LED_ACTIVITY
+ /* check if we are binding activity LED and assign it */
+ if (!strcmp(priv->activity_led_label, uc_plat->label))
+ priv->activity_led_dev = dev;
+#endif
+
uc_plat->default_state = LEDST_COUNT;
default_state = dev_read_string(dev, "default-state");
@@ -242,13 +322,21 @@ static int led_post_probe(struct udevice *dev)
return ret;
}
-#ifdef CONFIG_LED_BOOT
+#if defined(CONFIG_LED_BOOT) || defined(CONFIG_LED_ACTIVITY)
static int led_init(struct uclass *uc)
{
struct led_uc_priv *priv = uclass_get_priv(uc);
+#ifdef CONFIG_LED_BOOT
priv->boot_led_label = ofnode_options_read_str("boot-led");
priv->boot_led_period = ofnode_options_read_int("boot-led-period", 250);
+#endif
+
+#ifdef CONFIG_LED_ACTIVITY
+ priv->activity_led_label = ofnode_options_read_str("activity-led");
+ priv->activity_led_period = ofnode_options_read_int("activity-led-period",
+ 250);
+#endif
return 0;
}
@@ -260,7 +348,7 @@ UCLASS_DRIVER(led) = {
.per_device_plat_auto = sizeof(struct led_uc_plat),
.post_bind = led_post_bind,
.post_probe = led_post_probe,
-#ifdef CONFIG_LED_BOOT
+#if defined(CONFIG_LED_BOOT) || defined(CONFIG_LED_ACTIVITY)
.init = led_init,
.priv_auto = sizeof(struct led_uc_priv),
#endif
diff --git a/include/led.h b/include/led.h
index ca495217777..bba8c0009ca 100644
--- a/include/led.h
+++ b/include/led.h
@@ -54,8 +54,11 @@ struct led_uc_plat {
* struct led_uc_priv - Private data the uclass stores about each device
*
* @boot_led_label: Boot LED label
+ * @activity_led_label: Activity LED label
* @boot_led_dev: Boot LED dev
+ * @activity_led_dev: Activity LED dev
* @boot_led_period: Boot LED blink period
+ * @activity_led_period: Activity LED blink period
*/
struct led_uc_priv {
#ifdef CONFIG_LED_BOOT
@@ -63,6 +66,11 @@ struct led_uc_priv {
struct udevice *boot_led_dev;
int boot_led_period;
#endif
+#ifdef CONFIG_LED_ACTIVITY
+ const char *activity_led_label;
+ struct udevice *activity_led_dev;
+ int activity_led_period;
+#endif
};
struct led_ops {
@@ -193,4 +201,48 @@ static inline int led_boot_blink(void)
}
#endif
+#ifdef CONFIG_LED_ACTIVITY
+
+/**
+ * led_activity_on() - turn ON the designated LED for activity
+ *
+ * Return: 0 if OK, -ve on error
+ */
+int led_activity_on(void);
+
+/**
+ * led_activity_off() - turn OFF the designated LED for activity
+ *
+ * Return: 0 if OK, -ve on error
+ */
+int led_activity_off(void);
+
+#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK)
+/**
+ * led_activity_blink() - turn ON the designated LED for activity
+ *
+ * Return: 0 if OK, -ve on error
+ */
+int led_activity_blink(void);
+#else
+/* If LED BLINK is not supported/enabled, fallback to LED ON */
+#define led_activity_blink led_activity_on
+#endif
+#else
+static inline int led_activity_on(void)
+{
+ return -ENOSYS;
+}
+
+static inline int led_activity_off(void)
+{
+ return -ENOSYS;
+}
+
+static inline int led_activity_blink(void)
+{
+ return -ENOSYS;
+}
+#endif
+
#endif
--
2.45.2
More information about the U-Boot
mailing list