[PATCH v2 5/7] ARM: socfpga: add Enclustra AA1 demo env files

[Marek Vasut]

On 9/17/24 8:21 AM, Lothar Rubusch wrote:
> Provide additional uboot.env text environment files meant as a generic
> demo. The default environment uses a uboot.env. The default environment
> works somehow.

What does this "somehow" mean ?

> This environment provides better support but only shows
> one possible approach used in the Enclustra reference design setups.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch at gmail.com>
> ---
>   board/enclustra/mercury_aa1/mercury_aa1.env | 65 +++++++++++++++++++++
>   1 file changed, 65 insertions(+)
>   create mode 100644 board/enclustra/mercury_aa1/mercury_aa1.env
> 
> diff --git a/board/enclustra/mercury_aa1/mercury_aa1.env b/board/enclustra/mercury_aa1/mercury_aa1.env
> new file mode 100644
> index 0000000000..07b4a95a75
> --- /dev/null
> +++ b/board/enclustra/mercury_aa1/mercury_aa1.env
> @@ -0,0 +1,65 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2024 Enclustra GmbH
> + * <info at enclustra.com>
> + *
> + * This is an example configuration file for uboot.env generation.
> + *
> + * Given ENV_FAT_FILE defaults to "uboot.env" and ENV_SIZE defaults to 0x80000
> + * (see configuration options). Then adjust the configuration to your needs and
> + * build the a binary .env file as follows
> + * $ ./tools/mkenvimage -s 0x80000 -o uboot.env ./board/enclustra/mercury_aa1/mercury_aa1.env
> + *
> + * NB: Without providing this binary uboot.env the board is supposed to come up

What does NB: mean ?

> + * with the generic environment based on the architecture. This can be helpful
> + * when upgrading and/or recuding environments.
> + */

Can you please pick one method of specifying board environment ? Either 
this or include/configs/board.h, but do not use both, that is confusing.

> +bitstream_size=0xD00000
> +bootargs=earlycon console=ttyS0,115200 rw rootwait root=/dev/mmcblk0p3
> +bootargs_qspi=earlycon console=ttyS0,115200 rw root=/dev/ram0
> +bootm_size=0x0a000000
> +devnum=0
> +devtype=mmc
> +distro_bootpart=1
> +env_size=0x80000
> +fdt_addr_r=0x10000000
> +fdtfile=system.dtb
> +fdtload=
> +	load ${devtype} ${devnum}:${distro_bootpart} ${fdt_addr_r} ${bootdir}/${fdtfile};
> +	load ${devtype} ${devnum}:${distro_bootpart} ${fdto_addr_r} ${bootdir}/${fdtofile};

&& instead of ;