[PATCH 1/2] net: fec_mxc: Fix clk_ref rate on iMX93

[Primoz Fiser]

Hi,

On 23. 09. 24 15:14, Peng Fan (OSS) wrote:
> From: Ye Li <ye.li at nxp.com>
> 
> Because iMX93 has a internal 1/2 divider before clock input to
> network controller, so have to set twice frequency rate
> 
> Fixes: 09de565f76b ("net: fec_mxc: support i.MX93")
> Signed-off-by: Ye Li <ye.li at nxp.com>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---
>  drivers/net/fec_mxc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 0a0d92bc2cd..e5d7f0f3e1e 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1215,6 +1215,9 @@ static int fecmxc_set_ref_clk(struct clk *clk_ref, phy_interface_t interface)
>  	else
>  		return -EINVAL;
>  
> +	if (is_imx93())
> +		freq = freq << 1;

Humm, but how did it work so far?

On phyboard-segin-imx93, this change breaks fec ethernet.

I had to revert this already in NXP downstream u-boot.

BR,
Primoz


> +
>  	ret = clk_set_rate(clk_ref, freq);
>  	if (ret < 0)
>  		return ret;

-- 
Primoz Fiser                    | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o.            | https://www.norik.com
<https://www.norik.com>  |
Your embedded software partner  | email: info at norik.com
<mailto:info at norik.com> |
Slovenia, EU                    | phone: +386-41-540-545
<tel:+386-41-540-545> |