[PATCH v1 04/20] arm: socfpga: agilex5: Add low level initialization

[Marek Vasut]

On 9/25/24 7:40 AM, Chee, Tien Fong wrote:

Hi,

>> arch/arm/cpu/armv7/lowlevel_init.S:.pushsection .text.s_init, "ax"
>> arch/arm/cpu/armv7/lowlevel_init.S:WEAK(s_init)
>> arch/arm/cpu/armv7/lowlevel_init.S:ENDPROC(s_init)
>> arch/arm/cpu/armv7/lowlevel_init.S:     bl      s_init
>>
>> Maybe such a default lowlevel_init for armv8 could also have an s_init ?
>>
>>> What's concern with lowlevel_init()? It's also wired into existing
>>> early hook function which's located inside start.S
>> I would like to avoid duplicating lowlevel_init functionality as much as
>> possible , common lowlevel_init would be very welcome .
> 
> Sure, I can add the s_init to common lowlevel_init and moving the codes to s_init.
Thanks. Then the question is, how much of this stuff can be removed 
because it is part of generic lowlevel_init, I hope a lot.