[PATCH v8 10/13] net/net: fix include ordering

Simon Glass sjg at chromium.org
Thu Sep 26 23:34:05 CEST 2024


On Wed, 25 Sept 2024 at 03:41, Mikhail Kshevetskiy
<mikhail.kshevetskiy at iopsys.eu> wrote:
>
> fix include ordering to follow
>   https://docs.u-boot.org/en/latest/develop/codingstyle.html#include-files
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> ---
>  net/net.c | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/net/net.c b/net/net.c
> index 86182cc504e..92156b5058b 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -88,41 +88,43 @@
>  #include <errno.h>
>  #include <image.h>
>  #include <log.h>
> +#if defined(CONFIG_LED_STATUS)
> +#include <miiphy.h>
> +#endif
>  #include <net.h>
>  #include <net6.h>
>  #include <ndisc.h>
> +#if defined(CONFIG_LED_STATUS)
> +#include <status_led.h>
> +#endif
> +#include <watchdog.h>
> +#include <linux/compiler.h>
>  #include <net/fastboot_udp.h>
>  #include <net/fastboot_tcp.h>
> -#include <net/tftp.h>
>  #include <net/ncsi.h>
>  #if defined(CONFIG_CMD_PCAP)
>  #include <net/pcap.h>
>  #endif
> -#include <net/udp.h>
> -#if defined(CONFIG_LED_STATUS)
> -#include <miiphy.h>
> -#include <status_led.h>
> -#endif
> -#include <watchdog.h>
> -#include <linux/compiler.h>
> -#include <test/test.h>
>  #include <net/tcp.h>
> +#include <net/tftp.h>
> +#include <net/udp.h>
>  #include <net/wget.h>
> +#include <test/test.h>
>  #include "arp.h"
>  #include "bootp.h"
>  #include "cdp.h"
> +#include "dhcpv6.h"
>  #if defined(CONFIG_CMD_DNS)
>  #include "dns.h"
>  #endif
>  #include "link_local.h"
> +#include "net_rand.h"
>  #include "nfs.h"
>  #include "ping.h"
>  #include "rarp.h"
>  #if defined(CONFIG_CMD_WOL)
>  #include "wol.h"
>  #endif
> -#include "dhcpv6.h"
> -#include "net_rand.h"
>
>  /** BOOTP EXTENTIONS **/
>
> --
> 2.45.2
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list