[PATCH 19/27] mx23_olinuxino: Drop status-LED code

[Marek Vasut]

On 9/27/24 12:43 PM, Simon Glass wrote:
> Hi Marek,

Hi,

> On Fri, 27 Sept 2024 at 00:20, Marek Vasut <marex at denx.de> wrote:
>>
>> On 9/27/24 12:10 AM, Simon Glass wrote:
>>> Hi Marek,
>>
>> Hello Simon,
>>
>>> On Thu, 26 Sept 2024 at 23:40, Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> On 9/26/24 10:44 PM, Simon Glass wrote:
>>>>> This is not used anymore, so drop it.
>>>>>
>>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>>> ---
>>>>>
>>>>>     board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 -------
>>>>>     1 file changed, 7 deletions(-)
>>>>>
>>>>> diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>>>>> index b2bb6678c23..78136c1620a 100644
>>>>> --- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>>>>> +++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>>>>> @@ -13,9 +13,6 @@
>>>>>     #include <asm/arch/imx-regs.h>
>>>>>     #include <asm/arch/clock.h>
>>>>>     #include <asm/arch/sys_proto.h>
>>>>> -#ifdef CONFIG_LED_STATUS
>>>>> -#include <status_led.h>
>>>>> -#endif
>>>>>     #include <linux/delay.h>
>>>>>
>>>>>     DECLARE_GLOBAL_DATA_PTR;
>>>>> @@ -61,9 +58,5 @@ int board_init(void)
>>>>>         /* Adress of boot parameters */
>>>>>         gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>>>>>
>>>>> -#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT_ENABLE)
>>>>> -     status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_STATE);
>>>>> -#endif
>>>> Why not define the GPIO LED in DT, it might even already be defined there.
>>>
>>> Yes I see it in the DT for quite a few boards, so that's what we should use.
>> Since LED uclass already uses well established DM_FLAG_PROBE_AFTER_BIND
>> flag, the update here should be only a matter of enabling DM LED and
>> GPIO LED driver.
> 
> Yes, fair enough, but I hope you are not suggesting I try and do it?

Turn on the Kconfig options , that's all I am asking .

> I'm OK with that flag with LEDs. It is regulators where I get nervous.
OK