[PATCH v2 1/7] usb: onboard-hub: Add reset-gpio support

[Marek Vasut]

On 9/27/24 9:01 AM, Venkatesh Yadav Abbarapu wrote:

[...]

> @@ -30,7 +40,24 @@ static int usb_onboard_hub_probe(struct udevice *dev)
>   	if (ret)
>   		dev_err(dev, "can't enable vdd-supply: %d\n", ret);
>   
> -	return ret;
> +	hub->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> +						  GPIOD_IS_OUT | GPIOD_ACTIVE_LOW);
> +	/* property is optional, don't return error! */
> +	if (hub->reset_gpio) {
> +		ret = dm_gpio_set_value(hub->reset_gpio, 1);
> +		if (ret)
> +			return ret;
> +
> +		udelay(data->reset_us);

Where is this assigned ?

> +
> +		ret = dm_gpio_set_value(hub->reset_gpio, 0);
> +		if (ret)
> +			return ret;
> +
> +		udelay(data->power_on_delay_us);
> +	}

Is the reset asserted time and post-reset time identical for all USB 
HUBs ? I don't think it is.

> +	return 0;
>   }
[...]