[PATCH 2/3] mtd: rawnand: denali: Remove always true test

Andrew Goodbody andrew.goodbody at linaro.org
Fri Aug 1 11:54:05 CEST 2025


In denali_wait_for_irq the code will either return from inside the while
loop or exit with time_left being 0. The following test for time_left
being 0 is guranteed to be true so remove the test and the following
unreachable code.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
 drivers/mtd/nand/raw/denali.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
index b2401116689..39cb641e0b3 100644
--- a/drivers/mtd/nand/raw/denali.c
+++ b/drivers/mtd/nand/raw/denali.c
@@ -173,13 +173,9 @@ static uint32_t denali_wait_for_irq(struct denali_nand_info *denali,
 		time_left--;
 	}
 
-	if (!time_left) {
-		dev_err(denali->dev, "timeout while waiting for irq 0x%x\n",
-			irq_mask);
-		return 0;
-	}
-
-	return denali->irq_status;
+	dev_err(denali->dev, "timeout while waiting for irq 0x%x\n",
+		irq_mask);
+	return 0;
 }
 
 static uint32_t denali_check_irq(struct denali_nand_info *denali)

-- 
2.39.5



More information about the U-Boot mailing list