[PATCH 2/3] mtd: rawnand: stm32_fmc2: Ensure to return error code
Andrew Goodbody
andrew.goodbody at linaro.org
Fri Aug 1 12:39:14 CEST 2025
In stm32_fmc2_nfc_probe there are 3 error returns that do not set the
error code before returning which could lead to the error being silently
ignored. Just return -EINVAL in each case.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
index 083ea4c5a74..d1c88643c98 100644
--- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
@@ -942,21 +942,21 @@ static int stm32_fmc2_nfc_probe(struct udevice *dev)
addr = dev_read_addr_index(dev, mem_region);
if (addr == FDT_ADDR_T_NONE) {
dev_err(dev, "Resource data_base not found for cs%d", chip_cs);
- return ret;
+ return -EINVAL;
}
nfc->data_base[chip_cs] = addr;
addr = dev_read_addr_index(dev, mem_region + 1);
if (addr == FDT_ADDR_T_NONE) {
dev_err(dev, "Resource cmd_base not found for cs%d", chip_cs);
- return ret;
+ return -EINVAL;
}
nfc->cmd_base[chip_cs] = addr;
addr = dev_read_addr_index(dev, mem_region + 2);
if (addr == FDT_ADDR_T_NONE) {
dev_err(dev, "Resource addr_base not found for cs%d", chip_cs);
- return ret;
+ return -EINVAL;
}
nfc->addr_base[chip_cs] = addr;
}
--
2.39.5
More information about the U-Boot
mailing list