Smatch report for drivers/net/phy/marvell10g.c

[Tom Rini]

On Tue, Aug 05, 2025 at 05:30:49PM +0100, Andrew Goodbody wrote:

> I have these Smatch reports.
> 
> drivers/net/phy/marvell10g.c:384 mv3310_select_mactype() warn: was ||
> intended here instead of &&?
> drivers/net/phy/marvell10g.c:387 mv3310_select_mactype() warn: was ||
> intended here instead of &&?
> drivers/net/phy/marvell10g.c:390 mv3310_select_mactype() warn: was ||
> intended here instead of &&?
> 
> Now there is obviously incorrect code there as it cannot work correctly as
> is, phydev->interface cannot equal two different enums at the same time, but
> simply swapping the && for || is not going to work either. Could anyone
> please point me in the direction of a fix?

Adding Marek as r8a779f0_spider and r8a779f4_s4sk are the only two
boards which enable CONFIG_PHY_MARVELL_10G (aside, ./tools/qconfig.py -b
and then ./tools/qconfig.py -f CONFIG_FOO is handy to see what boards
enable a given option and helpful when get_maintainer.pl has nothing
specific).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250806/e92b2601/attachment.sig>