[PATCH 2/2] pinctrl: qcom: sdm845: Limit check off by 1

Andrew Goodbody andrew.goodbody at linaro.org
Thu Aug 7 13:20:02 CEST 2025


The driver specifies 154 pins so should have a maximum selector of 153
to ensure that the index into the array special_pins_names does not
overflow.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-sdm845.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c
index 3f55fc81c8e..24b42e94c7a 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdm845.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c
@@ -72,7 +72,7 @@ static const char *sdm845_get_pin_name(struct udevice *dev,
 		"sdc2_data",
 	};
 
-	if (selector >= 150 && selector <= 154)
+	if (selector >= 150 && selector <= 153)
 		snprintf(pin_name, MAX_PIN_NAME_LEN, special_pins_names[selector - 150]);
 	else
 		snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector);

-- 
2.39.5



More information about the U-Boot mailing list