[PATCH] clk: Return value calculated by ERR_PTR
Andrew Goodbody
andrew.goodbody at linaro.org
Thu Aug 7 16:53:20 CEST 2025
On 14/07/2025 13:37, Quentin Schulz wrote:
> Hi Andrew,
>
> On 7/3/25 4:40 PM, Andrew Goodbody wrote:
>> In clk_set_default_get_by_id ret is passed to ERR_PTR but nothing is
>> done with the value that this calculates which is obviously not the
>> intention of the code. This is confirmed by the code around where this
>> function is called.
>
> Indeed, they do check the return code with IS_ERR() which indicates
> there should be something returning an error pointer somewhere, which
> doesn't happen right now?
>
> So this seems like a valid change to do.
>
> Acked-by: Quentin Schulz <quentin.schulz at cherry.de>
>
> Thanks!
> Quentin
Is there anything else needed to happen before this can be merged please?
Thanks,
Andrew
More information about the U-Boot
mailing list