[PATCH 6/6] power: regulator: tps65941: Cannot test unsigned for being negative
Andrew Goodbody
andrew.goodbody at linaro.org
Thu Aug 7 18:35:23 CEST 2025
In tps65941_buck_val and tps65941_ldo_val hex is an unsigned variable
being assigned the return value from a function that returns int. Change
hex to be an int so that the following test for an error as a negative
value will work as expected.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
drivers/power/regulator/tps65941_regulator.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/power/regulator/tps65941_regulator.c b/drivers/power/regulator/tps65941_regulator.c
index 13f94b730d4..2561d6f4c6c 100644
--- a/drivers/power/regulator/tps65941_regulator.c
+++ b/drivers/power/regulator/tps65941_regulator.c
@@ -277,8 +277,8 @@ static const struct tps65941_reg_conv_ops buck_conv_ops[] = {
static int tps65941_buck_val(struct udevice *dev, int op, int *uV)
{
- unsigned int hex, adr;
- int ret, delta, uwait, slew, idx;
+ unsigned int adr;
+ int hex, ret, delta, uwait, slew, idx;
struct dm_regulator_uclass_plat *uc_pdata;
const struct tps65941_reg_conv_ops *conv_ops;
ulong chip_id;
@@ -479,8 +479,8 @@ static const struct tps65941_reg_conv_ops ldo_conv_ops[] = {
static int tps65941_ldo_val(struct udevice *dev, int op, int *uV)
{
- unsigned int hex, adr;
- int ret, ret_volt, idx, ldo_bypass;
+ unsigned int adr;
+ int hex, ret, ret_volt, idx, ldo_bypass;
struct dm_regulator_uclass_plat *uc_pdata;
const struct tps65941_reg_conv_ops *conv_ops;
ulong chip_id;
--
2.39.5
More information about the U-Boot
mailing list