[PATCH] pinctrl: nexell: Cannot test unsigned to be negative

[Stefan Bosch]

Hi Andrew,

thanks a lot for fixing this Bug :-)

Regards
Stefan

On 07.08.25 11:16, Andrew Goodbody wrote:
> In s5pxx18_pinctrl_set_state testing count to be negative will always
> fail as count is unsigned despite receiving the return value of a
> function that returns an int. Change count and idx to be of type int to
> allow the test to work as expected and remove the need for any implicit
> casts. Also change pin to be u32 which is what all called functions
> expect.
> 
> This issue was found by Smatch.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
> ---
>   drivers/pinctrl/nexell/pinctrl-s5pxx18.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/nexell/pinctrl-s5pxx18.c b/drivers/pinctrl/nexell/pinctrl-s5pxx18.c
> index e7d0994f29e..a6ae5764fbc 100644
> --- a/drivers/pinctrl/nexell/pinctrl-s5pxx18.c
> +++ b/drivers/pinctrl/nexell/pinctrl-s5pxx18.c
> @@ -130,7 +130,8 @@ static int is_pin_alive(const char *name)
>   static int s5pxx18_pinctrl_set_state(struct udevice *dev,
>   				     struct udevice *config)
>   {
> -	unsigned int count, idx, pin;
> +	u32 pin;
> +	int count, idx;
>   	unsigned int pinfunc, pinpud, pindrv;
>   	unsigned long reg;
>   	const char *name;
> 
> ---
> base-commit: 3526f990b77fca1c933f1d8b24eb9385010a05bf
> change-id: 20250807-pinctrl_nexell-bc6669ff52e9
> 
> Best regards,