[PATCH 1/6] Revert "pmic: pca9450: Add optional SD_VSEL GPIO for LDO5"

Frieder Schrempf frieder at fris.de
Mon Aug 11 15:11:57 CEST 2025


From: Frieder Schrempf <frieder.schrempf at kontron.de>

This reverts commit 2add0511757e2c5897a88b57c5ea8c912140e60f.

It turns out that all boards using the PCA9450 actually have the
SD_VSEL input connected to the VSELECT signal of the SoCs SD/MMC
interface. Therefore we don't need manual control for this signal
via GPIO and there aren't any users.

This is equivalent to the following change in Linux:

c73be62caabb ("Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5"")

Signed-off-by: Frieder Schrempf <frieder.schrempf at kontron.de>
---
 drivers/power/pmic/pca9450.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
index 9d875f8bdbe..0e3d14abf15 100644
--- a/drivers/power/pmic/pca9450.c
+++ b/drivers/power/pmic/pca9450.c
@@ -6,12 +6,9 @@
 #include <fdtdec.h>
 #include <errno.h>
 #include <dm.h>
-#include <dm/device_compat.h>
 #include <i2c.h>
-#include <linux/err.h>
 #include <log.h>
 #include <asm/global_data.h>
-#include <asm-generic/gpio.h>
 #include <linux/printk.h>
 #include <power/pmic.h>
 #include <power/regulator.h>
@@ -29,10 +26,6 @@ static const struct pmic_child_info pmic_children_info[] = {
 	{ },
 };
 
-struct pca9450_priv {
-	struct gpio_desc *sd_vsel_gpio;
-};
-
 static int pca9450_reg_count(struct udevice *dev)
 {
 	return PCA9450_REG_NUM;
@@ -85,21 +78,7 @@ static int pca9450_bind(struct udevice *dev)
 
 static int pca9450_probe(struct udevice *dev)
 {
-	struct pca9450_priv *priv = dev_get_priv(dev);
 	unsigned int reset_ctrl;
-	int ret = 0;
-
-	if (CONFIG_IS_ENABLED(DM_GPIO) && CONFIG_IS_ENABLED(DM_REGULATOR_PCA9450)) {
-		priv->sd_vsel_gpio = devm_gpiod_get_optional(dev, "sd-vsel",
-							     GPIOD_IS_OUT |
-							     GPIOD_IS_OUT_ACTIVE);
-		if (IS_ERR(priv->sd_vsel_gpio)) {
-			ret = PTR_ERR(priv->sd_vsel_gpio);
-			dev_err(dev, "Failed to request SD_VSEL GPIO: %d\n", ret);
-			if (ret)
-				return ret;
-		}
-	}
 
 	if (ofnode_read_bool(dev_ofnode(dev), "nxp,wdog_b-warm-reset"))
 		reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_WARM;
@@ -132,5 +111,4 @@ U_BOOT_DRIVER(pmic_pca9450) = {
 	.bind = pca9450_bind,
 	.probe = pca9450_probe,
 	.ops = &pca9450_ops,
-	.priv_auto = sizeof(struct pca9450_priv),
 };
-- 
2.50.1



More information about the U-Boot mailing list