CONFIG_SYS_EARLY_PCI_INIT for PCI-attached eMMC

[Tom Rini]

On Thu, Aug 14, 2025 at 04:10:13PM +0200, Heinrich Schuchardt wrote:
> On 14.08.25 15:27, Fabio Estevam wrote:
> > On Thu, Aug 14, 2025 at 9:52 AM Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
> > 
> > > Not without removing the 2nd pci_init_r() that is conditionalized on
> > > !CONFIG_IS_ENABLED(SYS_EARLY_PCI_INIT).
> > > 
> > > That would require some thorough testing though; I certainly wouldn't
> > > be sure calling pci_init_r() is safe at that point on the boards I
> > > maintain.
> > 
> > You're right.
> > 
> > Maybe we could solve it with two patches:
> > 
> > 1. Convert EARLY_PCI_INIT to a Kconfig symbol:
> > 
> > diff --git a/common/Kconfig b/common/Kconfig
> > index a2f653f7e722..9119a1c0869f 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -824,6 +824,13 @@ config SYS_I2C_EEPROM_NXID
> > 
> >   endchoice
> > 
> > +config EARLY_PCI_INIT
> 
> Please, do not rename the symbol.
> 
> %s/EARLY_PCI_INIT/SYS_EARLY_PCI_INIT/
> 
> All configuration symbols starting on CONFIG_ should be defined in Kconfig.
> Only CFG_* are not Kconfig. Something must have gone wrong in the conversion
> work some years ago.

FWIW, this symbol is one of the cases where nothing enabled the CONFIG
option. So yes, it needs to be added to Kconfig now in order to enable
it, now that something want it. But that's how it was missed, and there
may be other symbols beyond this and CONFIG_SYS_FAULT_MII_ADDR that I
tripped on when doing allyesconfig.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250814/288f1d8c/attachment.sig>