[PATCH 4/4] pinctrl: zynqmp: Avoid using uninitialised variable

[Michal Simek]

On 8/7/25 12:04, Andrew Goodbody wrote:
> In zynqmp_pinconf_set if param is PIN_CFG_IOSTANDARD or
> PIN_CONFIG_POWER_SOURCE and zynqmp_pm_pinctrl_get_config returns an
> error then value will not be assigned to when its value is tested to be
> not equal to arg. Add code to only test value not equal to arg if ret is
> false.
> 
> This issue was found by Smatch.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
> ---
>   drivers/pinctrl/pinctrl-zynqmp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
> index 27dadbff8ca..665b76a7d4d 100644
> --- a/drivers/pinctrl/pinctrl-zynqmp.c
> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
> @@ -460,14 +460,14 @@ static int zynqmp_pinconf_set(struct udevice *dev, unsigned int pin,
>   	case PIN_CFG_IOSTANDARD:
>   		param = PM_PINCTRL_CONFIG_VOLTAGE_STATUS;
>   		ret = zynqmp_pm_pinctrl_get_config(pin, param, &value);
> -		if (arg != value)
> +		if (!ret && arg != value)
>   			dev_warn(dev, "Invalid IO Standard requested for pin %d\n",
>   				 pin);
>   		break;
>   	case PIN_CONFIG_POWER_SOURCE:
>   		param = PM_PINCTRL_CONFIG_VOLTAGE_STATUS;
>   		ret = zynqmp_pm_pinctrl_get_config(pin, param, &value);
> -		if (arg != value)
> +		if (!ret && arg != value)
>   			dev_warn(dev, "Invalid IO Standard requested for pin %d\n",
>   				 pin);
>   		break;
> 

Applied.
M