[PATCH 1/2] clk: scmi: fix set_parent support when CCF is not being used

Kamlesh Gurudasani kamlesh at ti.com
Mon Aug 18 12:10:39 CEST 2025


Peng Fan <peng.fan at oss.nxp.com> writes:

> On Wed, Aug 13, 2025 at 03:59:35PM +0530, Kamlesh Gurudasani wrote:
>>When not using Common clock framework(CCF), calls to
>>scmi_clk_set_parent returns -ENOTSUPP, which should not be the case.
>>Fix that.
>>
>>Fixes: 15fdfef6642c ("clk: scmi: check the clock state/parent/rate
>>control permissions)
>>
>>Signed-off-by: Kamlesh Gurudasani <kamlesh at ti.com>
>>---
>> drivers/clk/clk_scmi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/clk/clk_scmi.c b/drivers/clk/clk_scmi.c
>>index 0c9a81cabcc..83ea7bb4286 100644
>>--- a/drivers/clk/clk_scmi.c
>>+++ b/drivers/clk/clk_scmi.c
>>@@ -359,7 +359,7 @@ static int scmi_clk_set_parent(struct clk *clk, struct clk *parent)
>> 	int ret;
>> 
>> 	if (!CONFIG_IS_ENABLED(CLK_CCF))
>>-		return -ENOTSUPP;
>>+		return __scmi_clk_set_parent(clk, parent);
>
> The CCF check should be dropped per my understanding. The function should
> work w/o CCF.
Hi Peng, thanks for the review.

w/o CCF clk_get_by_id returns negative.
so function fails

Regards,
Kamlesh
>
> Regards,
> Peng
>
>> 
>> 	ret = clk_get_by_id(clk->id, &c);
>> 	if (ret)
>>
>>-- 
>>2.34.1
>>


More information about the U-Boot mailing list