[PATCH] fpga: cyclon2: Remove message never printed

Michal Simek michal.simek at amd.com
Mon Aug 18 14:05:25 CEST 2025



On 8/4/25 11:08, Alexander Dahl wrote:
> else branch is never reached.  Print "Done." anyways to keep behaviour.
> 
> Addresses-Coverity-ID: 583148
> Link: https://lore.kernel.org/u-boot/20250725132645.GA1807455@bill-the-cat/
> Fixes: f0ff4692ff33 ("Add FPGA Altera Cyclone 2 support Patch by Heiko Schocher, 15 Aug 2006")
> Signed-off-by: Alexander Dahl <ada at thorsis.com>
> ---
>   drivers/fpga/cyclon2.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/fpga/cyclon2.c b/drivers/fpga/cyclon2.c
> index 7e78d6e2d6c..1c464c1e912 100644
> --- a/drivers/fpga/cyclon2.c
> +++ b/drivers/fpga/cyclon2.c
> @@ -174,10 +174,7 @@ static int CYC2_ps_load(Altera_desc *desc, const void *buf, size_t bsize)
>   		ret_val = FPGA_SUCCESS;
>   
>   #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK
> -		if (ret_val == FPGA_SUCCESS)
> -			puts("Done.\n");
> -		else
> -			puts("Fail.\n");
> +		puts("Done.\n");
>   #endif
>   
>   		/*
> 
> base-commit: ae5711f881100f856ead1e76832c32b92dba93c7

Applied.
M


More information about the U-Boot mailing list