[PATCH] efi: Select also CMD_DHCP from EFI_HTTP_BOOT

[Jan Kiszka]

On 20.08.25 07:04, Jan Kiszka wrote:
> On 19.08.25 16:45, Heinrich Schuchardt wrote:
>> On 19.08.25 16:33, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka at siemens.com>
>>>
>>> This is needed because distro_efi_read_bootflow_net will then need
>>> dhcp_run which is not already enabled by CMD_NET.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
>>> ---
>>>   lib/efi_loader/Kconfig | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>>> index c2aa88f59fb..a4055e1cb43 100644
>>> --- a/lib/efi_loader/Kconfig
>>> +++ b/lib/efi_loader/Kconfig
>>> @@ -564,6 +564,7 @@ config EFI_HTTP_BOOT
>>>       bool "EFI HTTP Boot support"
>>>       depends on NET || NET_LWIP
>>>       select CMD_NET
>>> +    select CMD_DHCP
>>
>> It would be preferable to get rid of all CMD_* symbols here. They are
>> just the result of missing separation of CLI and library.
>>
>> DHCP is not needed to boot via HTTP. You can manually set up a network
>> interface.
> 
> As I wrote, we need it in order to even compile U-Boot.
> 
> Should we rather wrap some bits with #if defined(CONFIG_CMD_DHCP)? Then
> tell me, which ones.
> 
>>
>> Please, change your patch to use "implies".
> 
> That would allow to disable CMD_DHCP again, resulting in a
> non-compilable configuration.
> 
> Jan
> 

If we should agree on "select", though, this might be more accurate:

diff --git a/boot/Kconfig b/boot/Kconfig
index 54ef7052c5c..2813a39b102 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -605,7 +605,8 @@ config BOOTMETH_EXTLINUX_PXE
 config BOOTMETH_EFILOADER
 	bool "Bootdev support for EFI boot"
 	depends on EFI_BINARY_EXEC
-	imply CMD_TFTPBOOT if CMD_NET
+	select CMD_TFTPBOOT if CMD_NET
+	select CMD_DHCP if CMD_NET
 	default y
 	help
 	  Enables support for EFI boot using bootdevs. This makes the


Turned out that CMD_TFTPBOOT has a similar hard dependency and was only
using imply so far. If you turn it off, the build is broken as well.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center