[PATCH 1/1] lib: use utf-8 as encoding for C includes

Tom Rini trini at konsulko.com
Thu Aug 21 17:02:20 CEST 2025


On Thu, Aug 21, 2025 at 09:09:01AM +0200, Heinrich Schuchardt wrote:
> On 21.08.25 02:22, Tom Rini wrote:
> > On Thu, Aug 21, 2025 at 01:17:11AM +0200, Heinrich Schuchardt wrote:
> > > Correct spelling of name 'Joan Lledó' in copyright comments.
> > > 
> > > This avoids warnings in CI:
> > > 
> > >      Skipping file './lib/lwip/lwip/contrib/ports/unix/posixlib/lwipopts.h'
> > >      due to unicode error
> > > 
> > >      Skipping file
> > >      './lib/lwip/lwip/contrib/ports/unix/posixlib/include/posix/sockets.h'
> > >      due to unicode error
> > > 
> > >      Skipping file
> > >      './lib/lwip/lwip/contrib/ports/unix/posixlib/include/posix/inet.h'
> > >      due to unicode error
> > > 
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > > ---
> > >   lib/lwip/lwip/contrib/ports/unix/posixlib/include/posix/inet.h  | 2 +-
> > >   .../lwip/contrib/ports/unix/posixlib/include/posix/sockets.h    | 2 +-
> > >   lib/lwip/lwip/contrib/ports/unix/posixlib/lwipopts.h            | 2 +-
> > >   3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > Which test does this and can we just tell it to ignore what are
> > essentially untouched upstream files?
> > 
> 
> One of these:
> 
> tools/dtoc/src_scan.py:629:                print("Skipping file '%s' due to
> unicode error" % fname)
> tools/dtoc/src_scan.py:654:                print("Skipping file '%s' due to
> unicode error" % fname)
> tools/dtoc/test_src_scan.py:87:                         r"Skipping file '.*'
> due to unicode error\s*")
> 
> The patch only changes the encoding, not the content of a comment.
> Why would you want to use codepage 437?

I don't want to touch upstream files if at all possible. Submit the fix
upstream too at least?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250821/a4bbfec8/attachment.sig>


More information about the U-Boot mailing list