[PATCH] tools: Wait for logo generation before stripping

[Jan Kiszka]

On 23.08.25 13:30, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka at siemens.com>
> 
> We otherwise risk that strip will fail because the bmp_logo binary is in
> use during a multi-job build.

Strike this: I had qemu-user registered which papered over that "make
cross_tools" actually runs foreign bmp_logo on the builder. Make the
build fails under normal conditions.

We need to disable that execution if CROSS_BUILD_TOOLS is enabled. Patch
follows.

> 
> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
> ---
> 
> Also feels a bit strange that the logo data is generated when one asks 
> for building tools. As long as that is the case, we need such an 
> ordering.

But this behavior remains ugly.

Jan

> 
>  tools/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 02297e8c93a..9b8a89e66e6 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -356,7 +356,7 @@ override HOSTCFLAGS = $(CFLAGS)
>  
>  quiet_cmd_crosstools_strip = STRIP   $^
>        cmd_crosstools_strip = $(STRIP) $^; touch $@
> -$(obj)/.strip: $(call objectify,$(filter $(always),$(hostprogs-y)))
> +$(obj)/.strip: $(call objectify,$(filter $(always),$(hostprogs-y))) $(LOGO-y)
>  	$(call cmd,crosstools_strip)
>  
>  always += .strip

-- 
Siemens AG, Foundational Technologies
Linux Expert Center