[PATCH v3] Add imx8mp-libra-fpsc board

[Fabio Estevam]

Hi Teresa,

On Tue, Aug 26, 2025 at 9:19 AM Teresa Remmet <t.remmet at phytec.de> wrote:

> > +
> > +/* ddr timing config params */
> > +struct dram_timing_info dram_timing = {
> > +       .ddrc_cfg = ddr_ddrc_cfg,
> > +       .ddrc_cfg_num = ARRAY_SIZE(ddr_ddrc_cfg),
> > +       .ddrphy_cfg = ddr_ddrphy_cfg,
> > +       .ddrphy_cfg_num = ARRAY_SIZE(ddr_ddrphy_cfg),
> > +       .fsp_msg = ddr_dram_fsp_msg,
> > +       .fsp_msg_num = ARRAY_SIZE(ddr_dram_fsp_msg),
> > +       .ddrphy_trained_csr = ddr_ddrphy_trained_csr,
> > +       .ddrphy_trained_csr_num = ARRAY_SIZE(ddr_ddrphy_trained_csr),
> > +       .ddrphy_pie = ddr_phy_pie,
> > +       .ddrphy_pie_num = ARRAY_SIZE(ddr_phy_pie),
> > +       .fsp_table = { 4000, },
> > +};
> > +
>
> please remove the empty line at EOF.

Yes, this causes a warning while applying this patch.

> > +Build U-Boot
> > +^^^^^^^^^^^^
> > +
> > +.. code-block:: bash
> > +
> > +   $ make flash.bin
>
> looks like this should be removed.

Correct.

> Teresa
>
>
> > +   $ make -j $(nproc) \
> > +          CROSS_COMPILE=aarch64-linux-gnu- \
> > +          imx8mp-libra-fpsc_defconfig \
> > +          flash.bin

There is no need to pass "flash.bin"

After running:

make  imx8mp-libra-fpsc_defconfig
make

The flash.bin will be generated automatically.

I'll wait for v4. Thanks