[PATCH v2] drivers: clk: agilex: Correct EMAC clock source selection

[Tom Rini]

On Fri, Aug 29, 2025 at 04:58:07AM +0000, Chee, Tien Fong wrote:
> 
> 
> > -----Original Message-----
> > From: Ravulapalli, Naresh Kumar <naresh.kumar.ravulapalli at altera.com>
> > Sent: Thursday, August 28, 2025 9:52 PM
> > To: u-boot at lists.denx.de
> > Cc: Marek Vasut <marek.vasut at mailbox.org>; Simon Goldschmidt
> > <simon.k.r.goldschmidt at gmail.com>; Chee, Tien Fong
> > <tien.fong.chee at altera.com>; Tom Rini <trini at konsulko.com>; Ravulapalli,
> > Naresh Kumar <naresh.kumar.ravulapalli at altera.com>
> > Subject: [PATCH v2] drivers: clk: agilex: Correct EMAC clock source selection
> > 
> > Fix the incorrect bit masking and bit shift used to compute EMAC control
> > which in turn is used to select EMAC clock from EMAC source A or B.
> > 
> > Signed-off-by: Naresh Kumar Ravulapalli
> > <nareshkumar.ravulapalli at altera.com>
> > ---
> >  drivers/clk/altera/clk-agilex.c | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/clk/altera/clk-agilex.c b/drivers/clk/altera/clk-agilex.c
> > index e1ddd02f356..2ad8cfd8856 100644
> > --- a/drivers/clk/altera/clk-agilex.c
> > +++ b/drivers/clk/altera/clk-agilex.c
> > @@ -1,6 +1,7 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > +// SPDX-License-Identifier: GPL-2.0+
> >  /*
> >   * Copyright (C) 2019 Intel Corporation <www.intel.com>
> > + * Copyright (C) 2025 Altera Corporation <www.altera.com>
> >   */
> > 
> >  #include <log.h>

This is a NAK here. You can't just change the license, especially
without calling it out in the commit message. And I'm not pleased with
"make a small change, add/extend copyright". I'm not going to run around
NAK'ing everything else you've sent but I'm going to ask you to stop
doing that for changes that are not significant in size or scope.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250829/75363e71/attachment.sig>